Thursday, October 04, 2018

Proposal: Did you take into Account this Factor?

Times out 4-0. Enacted by Brendan. Note that as the portion delineated under “surround this” does not exist in the MCP, the related instructions on commenting do nothing. Also, I’m taking “if statement” here to mean “code starting with an ‘if’ and inclusive of the code between its curly braces,” as otherwise we’re just going to end up with more busywork syntax-cleanup proposals. CfJ if you disagree.

Adminned at 06 Oct 2018 15:12:14 UTC

Create a rule named “Formatting”:

curly quotes are equivalent to strait quotes, and curly quotes in the ruleset may be changed to strait quotes by any program at any time.

In the Master Control Program, surround:

var GNDT = `__GNDT`;
accessCode = “__INPUT”
var MCPOutput = “”;
var GNDTArray = [];

With:

// GLOBAL VARIABLE SECTION

one line above it and

//END GLOBAL VARIABLE SECTION

one line below it.

create a function at the bottom of the Master Control Program:

function runAccessCodes(){
//accessCode
}

in the Master Control Program, move all if statements starting with:

if (accessCode ==

ignoring whitespace, to immediately beneath ‘//accessCode’

insert

runAccessCodes();

in the location of the first if statement moved by this proposal

This is just factoring, mostly so we can say things like "add `var tension = "__tensionLevel"` to the global variable section. Or new code to the runAccessCodes function instead of tripping over positions and complicated sentences. The refactor is not done yet, but I figured I may as well start.

Comments

Kevan: HE/HIM

10-04-2018 15:19:09 UTC

How much do we care that, taken at the literal character level, the first step of this would do nothing because the MCP as written in the ruleset uses straight quotemarks rather than curly ones?

(I guess it should be an explicit rule that we don’t care about this kind of thing.)

derrick: HE/HIM

10-04-2018 15:45:49 UTC

ok, how do I make it different? And yes, there should be an explicit rule about that.

Kevan: HE/HIM

10-04-2018 15:50:04 UTC

You have to change “Formatting: XHTML” to “Auto br” when editing the blog post, to stop ExpressionEngine from replacing quotemarks.

If you added a short quotemark-fixing rule as the first step of this proposal, it’d cover the rest of it.

derrick: HE/HIM

10-04-2018 16:04:24 UTC

Added. I hope the phrasing is solid.

Brendan: HE/HIM

10-04-2018 21:00:41 UTC

for

Kevan: HE/HIM

10-04-2018 22:13:16 UTC

for

Jumble:

10-05-2018 01:04:57 UTC

for